Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding RFC for password limitations removal epic task #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thesp0nge
Copy link
Contributor

Copy link
Member

@rjmateus rjmateus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution to this topic.
AFAIK, yast is collecting data and saves it to a file named "setup_env.sh". After this a shell script called ("/usr/lib/susemanager/bin/mgr-setup") that loads those properties [1] and setup everything.

I don't think it's possible to save that data in the database, since the creating is done during the setup. Changing this would mean refactoring most of the setup script.

It can be changed, but we would need to investigate what will break in the scripts.
For Suse Manager 5.0 we are developing a new tool to setup the containerized environment [2]. @cbosdo this is something in need to consider in this new code base.

Another option that we may explore in the future is to create some a dummy certificate to be able to start apache, and the have a simple webUI to collect all setupdata and bootstrap from in stages (first database, then we can save the configurations to there).

[1] https://github.com/uyuni-project/uyuni/blob/master/susemanager/bin/mgr-setup#L58
[2] https://github.com/uyuni-project/uyuni-tools

@rjmateus rjmateus requested review from cbosdo, mcalmer and admd July 26, 2023 15:45
@cbosdo
Copy link

cbosdo commented Jul 27, 2023

I don't think we need to move anything to database to properly handle passwords. It smells like a refactoring of the setup scripts which is now a collection of shell, python and perl scripts. Of course this can be done totally independently of the containerization of the server.

@thesp0nge
Copy link
Contributor Author

As you can see from my request, a huge refactor is exactly what I propose. How do you suggest removing password limitations?

@thesp0nge thesp0nge requested a review from renner July 27, 2023 07:35
@mcalmer
Copy link
Contributor

mcalmer commented Jul 27, 2023

I think one requirement is, that we need some passwords in clear text. Hashing them is not an option.
The one we can handle as hashes, are already stored in that way.
I think all the limitations are coming from cases where we need the password in clear text as we use it to login to a service, like login to the database.

@thesp0nge
Copy link
Contributor Author

@mcalmer can we enumerate which passwords we need in clear text and for which usage?
So we can evaluate the risk in the correct way.

@thesp0nge
Copy link
Contributor Author

any news on this?

@mcalmer
Copy link
Contributor

mcalmer commented Aug 14, 2023

We have password to authenticate against the DB itself in rhn.conf .
We ask also for a password for a self generated SSL Certificates. But they are not stored permanently.
We need them only to feed the commands at generation time.
We have other passwords stored in the DB to authenticate against SCC, VMware or Cloud (virtual-host-gatherer) container registries or RMT server in the cloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants